FIX: Vault::Api::Leases url to match Hashicorp Vault API #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @goodrum! |
rimitchell
pushed a commit
to rimitchell/vault-java-driver
that referenced
this pull request
Jul 22, 2019
FIX: Vault::Api::Leases url to match Hashicorp Vault API
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull-request modifies the URL used when performing a lease revoke. I ran into this issue using the Hashicorp Vault Jenkins plugin to create ondemand AWS credentials which needed to be revoked at the end of the step. The current URL returns a 404 since it does not exist or in my case a 403 as /sys/revoke wasn't in the Jenkins user policy.