-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
X-Vault-Token should be optional #183
Comments
The associated pull request has been merged into
Based on the stacktrace above, I suspect this is related to PR #175 from @denglertai... which was merged into Both the unit test suite and integration test suites passed successfully after #175 was merged, but it doesn't seem to be playing nice with #183 here. Could you guys (@Casz and @denglertai) please try running the integration tests from Aside from making sure that the test suites pass, I would like to give @bklawans a chance to respond to a question I've posed on PR #176. Either way, hopefully a new binary release can go out to Maven Central next week. |
I suspect it's a container issue? |
I haven't had time to have a look at the issue yet and I won't, unfortunately, find time to have a look at it this week. |
D0h 😆 I have some WIP that fixes code maturity and which is actually where I found the bug when rewriting the containers to This should fix the integration tests all together |
I think the proper follow up is actually #186 |
Trying to add support for interacting with Vault agent: jenkinsci/hashicorp-vault-plugin#36
Found out after much headache my issue was with vault-java-driver because it assumes vault-token is mandatory, which it is not in the case of the auto-auth use case for Vault agent. The null pointer results in 400 Bad Request.
Example of vault cli against the very same endpoint (ngrok used for inspection purpose 😓)
You can set up the vault agent to use auto-auth and handle the requesting the token. So the application does not need to be concerned about caching or reauthenticating against vault.
https://www.vaultproject.io/docs/agent/
The text was updated successfully, but these errors were encountered: