Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev #1244

Merged
merged 2 commits into from
Apr 26, 2023
Merged

Dev #1244

merged 2 commits into from
Apr 26, 2023

Conversation

migbash
Copy link
Collaborator

@migbash migbash commented Apr 26, 2023

📃 Squash Description

PRs

Bulleted list of Pull Requests Part of this merge to main

  • #3452 - example

Detailed

Grouped by Pull Request, with each section containing the issues relevant to set Pull Request - example

PR #73023

  • closes #56
  • closes #695

ℹ Type of change

Please delete options that are not relevant.

  • 🛠 Bug fix (non-breaking change which fixes an issue)
  • 🚀 New feature (non-breaking change which adds functionality)
  • ❌ Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 📃 This change requires a documentation update

🧰 How Has This Been Tested?

Please describe the tests that you ran to verify your changes.
by simply checking the appropiate checkbox

  • localhost
  • heroku | DEV

🔽 (Optional)
Test Configuration:

  • Firmware version:
  • Hardware:
  • Toolchain:
  • SDK:

✔ Self-checklist:

  • This code follows the style guidelines of this project
  • This code is self-reviewed
  • This code is commented, particularly in hard-to-understand areas
  • Documentation has been updated
  • This code does not generate new warnings
  • This code contains added tests that prove my fix is effective or that my feature works
  • This code new and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

⚠ Warning:

Please ensure that your code does not contain console without the if (dev) console...
to avoid memory overflows on the server. Or remove the console if no longer needed.

Please ensure that any GraphQL query used starts with the prefix - REDIS_CACHE_ or FRONTEND_.

@migbash migbash requested a review from jonsnowpt April 26, 2023 19:51
@migbash migbash self-assigned this Apr 26, 2023
@migbash migbash added the ⏳ [ST] validating In a passive-active state. Being inspected and checked. label Apr 26, 2023
@jonsnowpt jonsnowpt merged commit fd31537 into main Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⏳ [ST] validating In a passive-active state. Being inspected and checked.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants