Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix commit message escaping #164

Merged
merged 2 commits into from
Feb 10, 2022

Conversation

alvarezfr
Copy link
Contributor

fixes #125

Hi @BetaHuhn,

The source of the issue is related to the bash command substitution.

Replaced the execution of the git commit from using double quotes to single quotes. Also, replaced the escaped sequence to escape the single quotes instead of doubles. The escape is a bit funny but all the elements are required. In the git commit message (when inside of single quotes), the ' must be escaped with '\''.

After the change, the command substitution is not executed, and also the single quotes and double quotes inside the commit message are processed just fine.

@BetaHuhn BetaHuhn changed the title Fix/missing scaping Fix commit message escaping Feb 10, 2022
@BetaHuhn BetaHuhn changed the title Fix commit message escaping 🐛 Fix commit message escaping Feb 10, 2022
@BetaHuhn BetaHuhn merged commit 8f9e9fd into BetaHuhn:master Feb 10, 2022
@BetaHuhn
Copy link
Owner

Thanks for the fix @alvarezfr!

@BetaHuhnBot
Copy link
Collaborator

🎉 This PR is included in version 1.17.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@alvarezfr alvarezfr deleted the fix/missing-scaping branch September 1, 2023 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing escaping
3 participants