Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option "Automatically enable new mounts upon learning them" Bug #121

Closed
Veldryn opened this issue Oct 16, 2020 · 0 comments
Closed

Option "Automatically enable new mounts upon learning them" Bug #121

Veldryn opened this issue Oct 16, 2020 · 0 comments

Comments

@Veldryn
Copy link

Veldryn commented Oct 16, 2020

Environment

  • BeStride version: 1.0.2.1 and the versions before that
  • WoW version: 9.0.1

Steps to reproduce

I have the option "Automatically enable new mounts upon learning them" unchecked. I do not wish any new mounts be added automatically to my Mount profiles.
Now, if I learn a new mount...

Expected Behaviour

...the new mount should not get called automatically and should not get its checkbox checked in the "Mounts" tab.

The new mount doesn't get called automatically. This works exactly as it should.
But: there's a display issue. New mounts learned get their checkboxes checked in the mounts list, although they should not.

Debug Output

There's no bugs in the bugsack concerning this. Code works fine.

Together with a friend we have identified the error in the code, though. It's really just a visual thing, the boxes in the Mounts tab getting checked upon learning new mounts, no matter how I chose to set the "Automatically enable new mounts" option.

The error is in Bestride.lua, line 341
self.db.profile.mounts[mountType][mountID] = true
--> it must be false instead.

I have been playing with this fix for the last months and it worked fine - any new mounts appeared in the list just fine and stayed unchecked. Please let me know if you can acknowledge the bug and the fix, since you understand your code much better than I do. It would be lovely if you could put the fix in the next version for everyone.

@DanSheps DanSheps mentioned this issue Oct 29, 2020
DanSheps added a commit that referenced this issue Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant