Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small tweaks to the CreateTypedefs pass #68

Merged
merged 1 commit into from
Dec 22, 2022

Conversation

ds5678
Copy link
Collaborator

@ds5678 ds5678 commented Dec 22, 2022

  • <PrivateImplementationDetails> should be Il2Cpp namespace prefixed.
  • Revised the definition for injected Cpp2IL types to include any type whose namespace starts with Cpp2ILInjected.
    • For example, using the callanalyzer processing layer produces types in the Cpp2ILInjected.CallAnalysis namespace.

* <PrivateImplementationDetails> should be namespace prefixed
* Revised the definition for injected Cpp2IL types
Copy link
Member

@Kasuromi Kasuromi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the reason behind allowing <PrivateImplementationDetails> to be processed by the generator?

@ds5678
Copy link
Collaborator Author

ds5678 commented Dec 22, 2022

What is the reason behind allowing <PrivateImplementationDetails> to be processed by the generator?

It was already allowed. This just un-does the portion of #61 that placed it in the global namespace.

@Kasuromi
Copy link
Member

Kasuromi commented Dec 22, 2022

It was already allowed. This just un-does the portion of #61 that placed it in the global namespace.

My mistake, I see that now.

@Kasuromi Kasuromi merged commit 384d4ea into BepInEx:master Dec 22, 2022
@ds5678 ds5678 deleted the renaming-tweaks branch December 22, 2022 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants