Ensure Proper Layout for Non-ValueTypes #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks OK to me in terms of code. Was this tested yet on some other games than just TestGame? |
Yes, I haven't tried any Win32 games, but I think it's safe to assume it will work there as well. |
js6pak
approved these changes
Dec 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On some Unity versions, some types will have layout attributes assigned to them even though they are not of ValueType.
A prime example is
UnityEngine.LightProbesinsideUnityEngine.CoreModule.dllon 2018.4.36f1 (TestGame).This went unnoticed for a while until we switched to CoreCLR which is way stricter in terms of type loading.