Rework PlayerHead Getter. #1446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generate player head based on WebAPI (as it is faster) and GameProfile texture (require NMS). Cache is suitable for storing into file format. Add ability to add custom HeadCache object into local cache. Add ability to modify cache keeping length. Add ability to keep all, or just a single element into cache until server restart.
Poslovitch
added
Type: API
Poslovitch
reviewed
Jul 8, 2020
src/main/java/world/bentobox/bentobox/util/heads/HeadCache.java
Outdated
Show resolved
Hide resolved
Poslovitch
reviewed
Jul 8, 2020
tastybento
requested changes
Jul 9, 2020
There was a problem hiding this comment.
Overall this is really good. I am running it on the test server and I saw zero lag and no timings impact with it compared to the previous version which took avg of 264.92ms per. I recommend setting the cache to something big, like 1h or even longer. Thanks for this, we need this released asap to fix lag issue with Level.
src/main/java/world/bentobox/bentobox/util/heads/HeadGetter.java
Outdated
Show resolved
Hide resolved
Poslovitch
added
Status: Need revision
- config will store time in minutes. - default value will be 1h.
|
@BONNe Please allow maintainers to edit this PR. I cannot solve the merge conflict manually. |
|
The funniest part is that I cannot give access, as isaacs/github#1681 :D |
Poslovitch
added
Status: Done
|
Thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generate player head based on WebAPI (as it is faster) and GameProfile texture (require NMS).
A cache is suitable for storing into a file format. Not implemented, but it is possible to do it.
Add the ability to add custom HeadCache object into the local cache.
Add the ability to modify cache keeping length.
Add the ability to keep all, or just a single element into cache until the server restart.
NMS will not require a version update each time, as GameProfile is in a package that does not use version number.