[EXP][CMDBUF] L0 Immediate command-list support #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EwanC
reviewed
Dec 19, 2023
EwanC
reviewed
Dec 19, 2023
Bensuo
approved these changes
Dec 19, 2023
Comment on lines
753
to
755
| ZE2UR_CALL( | ||
| zeCommandQueueExecuteCommandLists, | ||
| (ZeCommandQueue, 1, &ZeCommandList, CommandListPtr->second.ZeFence)); |
There was a problem hiding this comment.
I think if we're now submitting the command list ourselves rather than through the queue we could probably not store it it in this iterator type to clean things up a little bit, since that was only necessary for that.
There was a problem hiding this comment.
The iterator still help us keep track of fences to release them in the command-buffer destructor. But it is true that we can also use a simpler container for that.
There was a problem hiding this comment.
I changed the way we track fences by using a vector instead of the CommandList map.
reble
reviewed
Dec 21, 2023
julianmi
approved these changes
Dec 28, 2023
Adds support for L0 immediate command-list. The command-list containing the graph operations is still batch cmd-list but graphs can now be submitted even though immediate queue is requested by users. Prefix and Suffix additional command list types follow the Queue type.
mfrancepillois
force-pushed
the
maxime/imm-cmd-list-support
branch
from
2004e99
to
3933753
Compare
|
Upstream UR PR : oneapi-src#1218 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for L0 immediate command-list.
The command-list containing the graph operations is still batch command-list but graphs can now be submitted even though immediate queue is requested by users.
Prefix and Suffix additional command list types follow Queue type.