Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: 500 Internal Server Error should be properly handled #30

Closed
BenB196 opened this issue Sep 30, 2019 · 1 comment
Closed

Bug: 500 Internal Server Error should be properly handled #30

BenB196 opened this issue Sep 30, 2019 · 1 comment

Comments

@BenB196
Copy link
Owner

BenB196 commented Sep 30, 2019

The following error should not result in a panic, instead it should result in the query being retried. A max of 10 retries should be allowed until a fatal error/panic is thrown. This limit is to prevent the program from building up a massive queue of in progress/failed queries which will eventually become impossible to handle.

error getting file events for ffs query: main_query
panic: Error with gathering file events POST: 500 Internal Server Error

goroutine 191656 [running]:
github.com/BenB196/crashplan-ffs-puller/ffsEvent.queryFetcher(0xc00012ed90, 0xa, 0xc00010c660, 0x17, 0xc00012eda0, 0xf, 0xc00012ed9a, 0x2, 0xc00012ed9c, 0x3, ...)
        /app/ffsEvent/ffsEvent.go:234 +0x2802
created by github.com/BenB196/crashplan-ffs-puller/ffsEvent.FFSQuery.func5
        /app/ffsEvent/ffsEvent.go:184 +0x1d5
BenB196 added a commit that referenced this issue Oct 1, 2019
A limit of 10 retries for a query is set to prevent a runaway of resource utilization/infinite in progress queries.

Resolves issue #21
Resolves issue #30

Corrected issue with logstash output location not being properly handled.

Resolves #31
@BenB196
Copy link
Owner Author

BenB196 commented Oct 1, 2019

Fixed in release v0.1.1.

@BenB196 BenB196 closed this as completed Oct 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant