Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: This line can cause WaitGroup is reused before previous Wait has returned #16

Closed
BenB196 opened this issue Sep 23, 2019 · 3 comments
Closed

Bug: This line can cause WaitGroup is reused before previous Wait has returned #16

BenB196 opened this issue Sep 23, 2019 · 3 comments

Comments

@BenB196
Copy link
Owner

BenB196 commented Sep 23, 2019

crashplan-ffs-puller/ffsEvent/ffsEvent.go

Line 185 in 5b39c83

wgQuery.Wait()

Causes a WaitGroup is reused before previous Wait has returned
@BenB196
Copy link
Owner Author

BenB196 commented Sep 23, 2019

This is a higher level issue where multiple places are missing proper wgQuery.Add(1) causing wgQuery to drop to 0 and thus breaking.

BenB196 added a commit that referenced this issue Sep 25, 2019
@BenB196
Fixed issue with missing waitgroup adds which would cause a panic
fe23cec 
Resovles issue #16
@BenB196
Copy link
Owner Author

BenB196 commented Sep 25, 2019

Something like this is needed to actually fix this.

https://stackoverflow.com/questions/16466320/is-there-a-way-to-do-repetitive-tasks-at-intervals

@BenB196 BenB196 closed this as completed Sep 25, 2019
@BenB196 BenB196 reopened this Sep 25, 2019
BenB196 added a commit that referenced this issue Sep 25, 2019
@BenB196
Actually fixed issue with goroutines breaking stuff
b545d32 
Fixes issue #16
@BenB196
Copy link
Owner Author

BenB196 commented Sep 26, 2019

Fixed in release v0.0.8.

@BenB196 BenB196 closed this as completed Sep 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@BenB196