-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Task4 #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Score: 100/100
https://wa015rf5vk.execute-api.eu-central-1.amazonaws.com/prod/products
https://d18i4kfgqmmqko.cloudfront.net
https://app.swaggerhub.com/apis/Bektur777/aws-shop-backend/1.0.0
don't forget to switch servers
Get product by id
https://wa015rf5vk.execute-api.eu-central-1.amazonaws.com/prod/products/3206ab55-a095-4409-b9ec-42a84be6ea95
FE PR:
Bektur777/nodejs-aws-shop-react#1
Task 4.1 is implemented (create_products.sh) ✅
Task 4.2 is implemented lambda links are provided and returns data✅
Task 4.3 is implemented lambda links are provided and products is stored in DB (call Task 4.2 to see the product)✅
+7.5 (All languages) - POST /products lambda functions returns error 400 status code if product data is invalid✅
+7.5 (All languages) - All lambdas return error 500 status code on any error (DB connection, any unhandled error in code)✅
+7.5 (All languages) - All lambdas do console.log for each incoming requests and their arguments✅
+7.5 (All languages) - Transaction based creation of product (in case stock creation is failed then related to this stock product is not created and not ready to be used by the end user and vice versa) (https://devcenter.kinvey.com/nodejs/tutorials/bl-transactional-support, https://docs.aws.amazon.com/amazondynamodb/latest/developerguide/transaction-apis.html)✅
Validation:
Example ->
{
"id": "string",
"title": "",
"description": "",
"price": -100,
"count": -100
}
I add validation that price and count must be positive than title must not be empty or null
Answer ->
Bad Request invalid product data