feat(tubular) make tubular configurable #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| bs4==0.0.1 | ||
| uvicorn==0.23.2 | ||
| youtube_dl==2021.12.17 |
There was a problem hiding this comment.
I'll eventually make my own stable fork of youtube_dl as of right now the version in the pip repository are borked so be careful with versions here.
|
Thanks for this by the way. Looks good besides the minor things above. Once those are fixed I'll test again and merge up. |
Beheadedstraw
approved these changes
Sep 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following changes make the image configurable for internal paths and ports.