change: Drop support for PHP < 8.1, Symfony < 5.4 and Symfony 6.0 - 6.3 #272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stof
reviewed
Nov 12, 2024
.github/workflows/build.yml
Outdated
| - php: 8.1 | ||
| symfony-version: '5.4' | ||
| - php: 8.1 | ||
| symfony-version: '6.4' |
There was a problem hiding this comment.
the step below expects symfony-version to be a version constraint. Using 6.4 here will make it install 6.4.0, which is not what we want
There was a problem hiding this comment.
Thanks @stof, good catch. I'd not registered the install here is different to the one in behat.
There was a problem hiding this comment.
Updated to ^5.4 and ^6.4 and verified github actions is now installing the latest of each series as expected.
In line with the new behat version support policy adopted in Behat/Behat#1503.
acoulton
force-pushed
the
drop-old-versions
branch
from
a176011 to
fc697ae
Compare
carlos-granados
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In line with the new behat version support policy adopted in Behat/Behat#1503.