Fix: first_or_none no longer mutates FindMany object (#1116) #1117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
staticxterm
requested changes
Jan 31, 2025
beanie/odm/queries/find.py
Outdated
| if not res: | ||
| return None | ||
| return res[0] | ||
| result = await self.to_list(1) |
There was a problem hiding this comment.
While the performance impact may be negligible, I would prefer if the query would be as efficient as possible, so that Mongo only has to return 1 result.
Please write this the old way (use your initial proposal), using self.limit(1).to_list() and resetting self.limit_number to the previous value after result is retrieved.
There was a problem hiding this comment.
Sorry, I didn't realise that motor returns the whole list when to_list(1) is called and just truncates it. I've looked into it now and saw that. Thanks, I made an amend to follow the ‘one commit’ rule.
eac0de
force-pushed
the
fix-first-or-none
branch
from
de92754 to
cd36684
Compare
staticxterm
approved these changes
Feb 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1116