This repository has been archived by the owner. It is now read-only.
debugger: fix debugger failure when passing commands with non-latin symbols #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Let0s
added a commit
that referenced
this pull request
Mar 24, 2017
* fix: move 'array_buffer_allocator' variable into 'NodeEngine' class * make only one global object and context for one engine, fix error on second script launch on the same engine * debugger: fix debugger failure when passing commands with non-latin symbols (#10) * fix: fix debugger disconnect after setting a breakpoint in file with non-latin name * change Client.buffer type to Buffer * fix * add get version functions * fix error when JS exception is thrown inside delphi callback (#12) * fix: move 'array_buffer_allocator' variable into 'NodeEngine' class * make only one global object and context for one engine, fix error on second script launch on the same engine * Feat: add "SetInactive" function to stop handling callbacks; refactor delphi callbacks * Feat: add variables and calling JS function without parameters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Debug agent incorrectly used Content-Length and cut Content-Length symbols instead of Content-Length bytes from debugger protocol messages. This causes incorrect command body extraction and parsing that leads to debugger disconnection.
This fixes debugger problem mistakenly reported here microsoft/vscode#17389