Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg: auto-mode/debug-mode #813

Merged
merged 7 commits into from
Feb 3, 2025
Merged

Conversation

tschettervictor
Copy link
Collaborator

@tschettervictor tschettervictor commented Jan 15, 2025

Implement "auto" mode -a (will start the jail automatically if it is stopped)

Implement "debug" mode -x (will show commands and their output)

@bmac2
Copy link
Collaborator

bmac2 commented Jan 17, 2025

but what good is a template that doesn't run correctly? What is the gain in it running with an error in it? I am struggling for the use case here.

@tschettervictor @yaazkal

@tschettervictor
Copy link
Collaborator Author

According to the discussion in #404 it seems we want a docker like method of continuing the template even if a command fails.

Correct me if I'm wrong.

@bmac2
Copy link
Collaborator

bmac2 commented Jan 20, 2025

per my reading of #404 @michael-o was saying to halt the template IF there is a missing parameter that the process halts and throws an error. NOT to cause the process to continue.

@michael-o am I misreading that issue?

@yaazkal @tschettervictor

@michael-o
Copy link
Contributor

per my reading of #404 @michael-o was saying to halt the template IF there is a missing parameter that the process halts and throws an error. NOT to cause the process to continue.

@michael-o am I misreading that issue?

@yaazkal @tschettervictor

Yes, totally correct, but I don't see any relation to this PR....

@tschettervictor tschettervictor changed the title pkg: auto-mode/debug-mode/notify instead of exit when done pkg: auto-mode/debug-mode Jan 26, 2025
@bmac2
Copy link
Collaborator

bmac2 commented Feb 3, 2025

tested and the -a and -x mode work merging

@bmac2 bmac2 merged commit af344fa into BastilleBSD:master Feb 3, 2025
1 check passed
@tschettervictor tschettervictor deleted the patch-4 branch February 3, 2025 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants