-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Recaptcha validation #2
Conversation
One concern you might have is why I named the parameter This name comes from Google Docs, and while we could easily rename it to something simpler, I find it important to stay as close to the native solution as possible. That will help people experienced with Google reCAPTCHA to easily use it in FormEasy without having to scan docs. On the other hand, this will create inconsistency between different captcha providers. This could be a valid reason to try to use specific words for all of them, like I would love to hear your feedback on this. |
Hey @Basharath 👋 |
Hey @Meldiron It is all good so far, I haven't merged yet. |
Awesome, I'll do so in the upcoming days. Ill also take my time with research to see what Captcha providers are most commonly used. |
Yeah, that's fine, you can take your time. Once done just update here. |
any ETA on merging of this PR? I am looking to use FormEasy with reCAPTCHA. Without CAPTCHA, it's just too much spam. |
I won't be able to research other providers any time soon. With that said, reCAPTCHA is properly implemented and tested. This PR can be merged, in my opinion. In the future, I will open a new PR to add new providers. Let me ping @Basharath about this. |
Hey, @Meldiron I thought to ask you about this a few days ago, meanwhile, this happened. I'll try merging this by this weekend and publish the new update. |
Feat: Recaptcha validation
Hey there 👋 I have created an implementation for Google reCAPTCHA V2 so we can start the code review process.
When we agree on the structure, let's keep the PR open and I will implement more providers before the final review and merge.
I did manual QA with solution in this PR and was able to get it working on my demo application:
Related to issue #1