Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open App settings in iOS #5

Merged
merged 6 commits into from
Jul 27, 2018
Merged

Conversation

mvanbeusekom
Copy link
Member

Added the openAppSettings API to iOS (note this PR adds to #4)

@mvanbeusekom mvanbeusekom requested a review from a team July 27, 2018 05:47
@martijn00 martijn00 merged commit c801269 into develop Jul 27, 2018
@martijn00 martijn00 added this to the 1.0 milestone Jul 31, 2018
@martijn00 martijn00 deleted the feature/ios_open_appsettings branch July 31, 2018 11:11
@dark-chocolate
Copy link

dark-chocolate commented Nov 29, 2018

bool canOpenSettingsPage = await PermissionHandler().openAppSettings();
Doc says, it returns true if settings page can be opened and false otherwise. However in iOS, it opens settings page but still false is returned. So, please correct your docs.

Edit: By docs I meant your plugin docs, not the official docs of IOS or Android.

@mvanbeusekom
Copy link
Member Author

@dark-chocolate, first the docs don't mention anything specific regarding the boolean being returned (which is definitely something we could/ need to approve on, pull-request are very welcome).

Second the idea of the boolean is not to indicate if the settings "can" be opened, but if it "was" opened successfully, meaning if true is returned the page has been opened and if false is returned the page could not be opened. Since you mentioned on iOS the a false is returned but the page is still opened I would say this is a bug and we need to look into that. To keep track of this bug I have create issue #52. Please feel free to add findings or other details there.

@dark-chocolate
Copy link

dark-chocolate commented Nov 30, 2018

@mvanbeusekom Is there also a way to open Settings page in iOS (Settings here doesn't mean my own app settings, it means the general Settings app of iPhone)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants