Replace rosbag2_format_output by direct source files linkage #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Also put `format_service_info(..)` and `format_bag_meta_data(..)` under the rosbag2_py namespace Signed-off-by: Michael Orlov <michael.orlov@apex.ai>
|
rosbag2_py/src/rosbag2_py/visibility_control.hpp is unused now. It is added in my last commit |
….hpp Signed-off-by: Michael Orlov <michael.orlov@apex.ai>
|
@Barry-Xu-2018 I've addressed your comments |
Barry-Xu-2018
merged commit 718bac6
into
Barry-Xu-2018:review/rosbag2_service_record_and_show
11 checks passed
MichaelOrlov
deleted the
morlov/address_windows_ci_warnings_in_service_recording
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
format_service_info(..)andformat_bag_meta_data(..)under the rosbag2_py namespace