Skip to content

Commit

Permalink
Disable test_burst for RTI DDS due to the failure with missing requests
Browse files Browse the repository at this point in the history
- The test `burst_bursting_only_filtered_services` fails only with
rmw_connext_dds for unknown reasons and tends to be flaky. Sometimes
we receive only one service request instead of 2.

Signed-off-by: Michael Orlov <michael.orlov@apex.ai>
  • Loading branch information
MichaelOrlov committed Apr 13, 2024
1 parent e95a51e commit aaaac74
Showing 1 changed file with 7 additions and 0 deletions.
7 changes: 7 additions & 0 deletions rosbag2_transport/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -326,11 +326,18 @@ if(BUILD_TESTING)
target_include_directories(test_burst PRIVATE $<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}/src/rosbag2_transport>)
target_link_libraries(test_burst rosbag2_transport ${test_msgs_TARGETS} rosbag2_test_common::rosbag2_test_common)
function(test_burst_for_rmw_implementation)
# Disable the following test_burst tests for connext_dds due to the
# burst_bursting_only_filtered_services test failure
set(SKIP_TEST "")
if(${rmw_implementation} MATCHES "rmw_connext(.*)")
set(SKIP_TEST "SKIP_TEST")
endif()
set(rmw_implementation_env_var RMW_IMPLEMENTATION=${rmw_implementation})

ament_add_gmock_test(test_burst
TEST_NAME test_burst${target_suffix}
ENV ${rmw_implementation_env_var}
${SKIP_TEST}
)
endfunction()
call_for_each_rmw_implementation(test_burst_for_rmw_implementation)
Expand Down

0 comments on commit aaaac74

Please sign in to comment.