Migrate the project to use the Jakarta API making it compatible with recent Java versions or newer framework versions #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…recent Java versions or newer framework versions.
bmariesan
commented
Jan 6, 2025
| @@ -55,7 +55,7 @@ public void testInvalidSiteDelete() throws Exception { | |||
| .withStatus(200) | |||
| .withBody(IrisClientTestUtils.validSiteResponseXml))); | |||
|
|
|||
| Site s = Site.get(getDefaultClient(), "1234"); | |||
| Site s = Site.get(getDefaultClient(), "2858"); | |||
There was a problem hiding this comment.
This test was working with the previous wiremock version, however after upgrading the lib, it started failing. Judging with my limited knowledge of bandwidth APIs I think the fix here makes sense, but again lmk if I missed something here
|
Hey @bmariesan - thanks for the contribution! we will look over the changes and get this tested and merged in! |
brianluisgomez
approved these changes
Jan 6, 2025
|
@bmariesan this change will get released tomorrow |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've noticed that the main SDK has compatibility with more recent Java versions or frameworks, however the iris SDK is using the older jaxb API. While the java migration is not required (I tested at least compatibility with Java 17 and seems to be working just fine), I assume the API can safely be migrated to the newer Jakarta API packages & runtimes.
There was one test that was failing after the migration and I also had to upgrade the wiremock API as it was causing some class cast exceptions (again due to it using jaxb/javax in the older versions).
Please let me know if there's anything else I need to test and/or change in order to cotribute the changes.