Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

closes #964 Improve error message for packet mutex breaking marshal dump #967

Merged
3 commits merged into from
Apr 2, 2019

Conversation

ghost
Copy link

@ghost ghost commented Apr 2, 2019

No description provided.

@ghost ghost self-requested a review April 2, 2019 17:29
@codecov-io
Copy link

codecov-io commented Apr 2, 2019

Codecov Report

Merging #967 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #967      +/-   ##
==========================================
+ Coverage   84.17%   84.17%   +<.01%     
==========================================
  Files         165      165              
  Lines       15675    15679       +4     
==========================================
+ Hits        13194    13198       +4     
  Misses       2481     2481
Impacted Files Coverage Δ
lib/cosmos/top_level.rb 85.32% <100%> (+0.14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 285a1f0...12833bd. Read the comment docs.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added spec to test for this but otherwise looks good.

@ghost ghost merged commit ff63725 into master Apr 2, 2019
@ghost ghost deleted the improve_no_dump_message branch April 2, 2019 21:27
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants