Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add local screens feature. Remove insert return. Add STAY_ON_TOP flag. #828

Merged
5 commits merged into from
Jul 13, 2018

Conversation

ghost
Copy link

@ghost ghost commented Jul 9, 2018

closes #812. closes #815

@ghost ghost self-requested a review July 9, 2018 19:24
@ghost
Copy link
Author

ghost commented Jul 9, 2018

closes #829

@ghost
Copy link

ghost commented Jul 12, 2018

Try the following. Modify the screen definition to cause an parser error. Then when you get to the screen.close method you segfault:
C:/git/cosmos/lib/cosmos/tools/tlm_viewer/screen.rb:579: [BUG] Segmentation fault
ruby 2.4.4p296 (2018-03-28 revision 63013) [x64-mingw32]

'
end

disable_instrumentation do
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Showing how to use this is a nice addition to the demo procedures.

TITLE "Local Variable and Target Display"

VERTICALBOX
LABELVALUE LOCAL LOCAL temp
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LOCAL LOCAL is just the tgt/pkt convention to access the local variable. I tried this with simply VALUE and FORMATVALUE and TEXTBOX with a text variable and all seemed to work well.

screen_def =
'
SCREEN AUTO AUTO 0.1 FIXED
STAY_ON_TOP
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works well. Nice addition.

@ghost ghost merged commit e84332a into master Jul 13, 2018
@ghost ghost deleted the local_screens branch July 13, 2018 19:49
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a temporary screen from a script Ruby 2.5 Instrumented Code outside of methods in a class
1 participant