Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Travis builds #767

Merged
4 commits merged into from
Apr 13, 2018
Merged

Update Travis builds #767

4 commits merged into from
Apr 13, 2018

Conversation

ghost
Copy link

@ghost ghost commented Apr 10, 2018

No description provided.

@codecov-io
Copy link

codecov-io commented Apr 12, 2018

Codecov Report

Merging #767 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #767      +/-   ##
==========================================
- Coverage   85.73%   85.72%   -0.02%     
==========================================
  Files         159      159              
  Lines       15026    15028       +2     
==========================================
  Hits        12883    12883              
- Misses       2143     2145       +2
Impacted Files Coverage Δ
lib/cosmos/utilities/ruby_lex_utils.rb 92.59% <100%> (+0.04%) ⬆️
lib/cosmos/io/json_drb.rb 98.69% <0%> (-0.66%) ⬇️
lib/cosmos/win32/win32.rb 22.27% <0%> (-0.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3763423...f8c5749. Read the comment docs.

@ghost
Copy link
Author

ghost commented Apr 12, 2018

@ryanatball I know we don't officially support Ruby 2.5 yet but this build passes. Let me know if you think we should merge.

@ghost
Copy link

ghost commented Apr 13, 2018

👍 It's passing... We will need to support Ruby 2.5 soon anyways so looks good.

@ghost ghost merged commit a5551d5 into master Apr 13, 2018
@ghost ghost deleted the travis_builds branch April 13, 2018 17:53
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants