Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split XTCE parser from packet_config #664

Merged
3 commits merged into from
Nov 30, 2017
Merged

Split XTCE parser from packet_config #664

3 commits merged into from
Nov 30, 2017

Conversation

ghost
Copy link

@ghost ghost commented Nov 21, 2017

I didn't go all the way with the coverage in XTCEParser but I setup some frameworks for the future

@ghost ghost self-requested a review November 21, 2017 17:27
@ghost
Copy link
Author

ghost commented Nov 21, 2017

closes #665

@codecov-io
Copy link

Codecov Report

Merging #664 into master will increase coverage by 2.33%.
The diff coverage is 63.14%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #664      +/-   ##
==========================================
+ Coverage   83.52%   85.86%   +2.33%     
==========================================
  Files         153      154       +1     
  Lines       14364    14484     +120     
==========================================
+ Hits        11998    12437     +439     
+ Misses       2366     2047     -319
Impacted Files Coverage Δ
lib/cosmos/packets/packet_item.rb 77.16% <100%> (+22.22%) ⬆️
lib/cosmos/packets/packet_config.rb 98.92% <100%> (+47.06%) ⬆️
lib/cosmos/packets/parsers/xtce_parser.rb 62.05% <62.05%> (ø)
lib/cosmos/tools/launcher/launcher_config.rb 96.74% <0%> (+1.62%) ⬆️
lib/cosmos/gui/qt.rb 37.03% <0%> (+1.74%) ⬆️
lib/cosmos/core_ext/string.rb 100% <0%> (+1.96%) ⬆️
lib/cosmos/config/config_parser.rb 92.38% <0%> (+3.08%) ⬆️
lib/cosmos.rb 93.1% <0%> (+3.44%) ⬆️
lib/cosmos/io/serial_driver.rb 92.85% <0%> (+3.57%) ⬆️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9be4e86...84eace0. Read the comment docs.

@ghost ghost mentioned this pull request Nov 22, 2017
@ghost
Copy link

ghost commented Nov 30, 2017

👍

@ghost ghost merged commit 5171e72 into master Nov 30, 2017
@ghost ghost deleted the xtce_parser branch November 30, 2017 19:53
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants