Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table report #1683

Merged
merged 13 commits into from
Jun 14, 2022
Merged

Table report #1683

merged 13 commits into from
Jun 14, 2022

Conversation

jmthomas
Copy link
Contributor

No description provided.

@jmthomas jmthomas requested review from a user and ryanmelt June 12, 2022 16:36
@codecov
Copy link

codecov bot commented Jun 12, 2022

Codecov Report

Merging #1683 (798ee84) into master (73c5e8a) will increase coverage by 0.34%.
The diff coverage is n/a.

❗ Current head 798ee84 differs from pull request most recent head 60b8805. Consider uploading reports for the commit 60b8805 to get more accurate results

@@            Coverage Diff             @@
##           master    #1683      +/-   ##
==========================================
+ Coverage   77.84%   78.18%   +0.34%     
==========================================
  Files         234      233       -1     
  Lines       18196    18110      -86     
==========================================
- Hits        14164    14160       -4     
+ Misses       4032     3950      -82     
Impacted Files Coverage Δ
app/controllers/application_controller.rb 88.88% <0.00%> (-11.12%) ⬇️
app/controllers/internal_status_controller.rb 83.33% <0.00%> (-2.39%) ⬇️
app/controllers/notes_controller.rb 54.68% <0.00%> (-0.39%) ⬇️
...b/cosmos/tools/table_manager/table_manager_core.rb 98.45% <0.00%> (-0.04%) ⬇️
config/routes.rb 100.00% <0.00%> (ø)
app/models/completed_script.rb
app/controllers/completed_script_controller.rb
lib/cosmos/topics/config_topic.rb 92.30% <0.00%> (ø)
lib/cosmos/models/microservice_model.rb 92.85% <0.00%> (+0.14%) ⬆️
lib/cosmos/models/target_model.rb 81.99% <0.00%> (+0.15%) ⬆️
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 73c5e8a...60b8805. Read the comment docs.

stage: test # It can run at the same time as unit-test-job (in parallel).
script:
- rubocop
- ls; ./cosmos-control.sh run
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you mean to leave the ls?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really but none of the gitlab stuff works right now anyway


# Authorize and rescue the possible execeptions
# @return [Boolean] true if authorize successful
def authorization(permission)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup

Copy link
Contributor

@ryanmelt ryanmelt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing playwright tests, otherwise looks good.

@ryanmelt
Copy link
Contributor

Also MetadataController does not inherit from ModelController so it is missing the authorization method.

@jmthomas jmthomas merged commit f785bd0 into master Jun 14, 2022
@jmthomas jmthomas deleted the table_report branch June 14, 2022 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants