Data extractor disconnects #1653
Conversation
ghost
self-requested a review
Codecov Report
@@ Coverage Diff @@
## master #1653 +/- ##
==========================================
- Coverage 77.85% 77.84% -0.02%
==========================================
Files 234 232 -2
Lines 18161 18122 -39
==========================================
- Hits 14140 14107 -33
+ Misses 4021 4015 -6
Continue to review full report at Codecov.
|
| import * as ActionCable from 'actioncable' | ||
| import * as ActionCable from '@rails/actioncable' | ||
| //ActionCable.logger.enabled = true | ||
| ActionCable.ConnectionMonitor.staleThreshold = 60 |
There was a problem hiding this comment.
Looks like the default is 6. Do you think this is what did it?
There was a problem hiding this comment.
This helped. The multiple files was the other main change.
| if (this.bytesReceived > 200000000) { | ||
| this.bytesReceived = 0 | ||
| this.createFile() | ||
| } |
There was a problem hiding this comment.
Yes. Otherwise the browser uses up tons of RAM. At this amount it still gets up to about 1 GB.
| end | ||
| false |
There was a problem hiding this comment.
We're not really using the return value (true/false) anymore. ReducerModel.rm_file(file) everytime. Not sure why that was in an if before but I don't think we ever returned false.
closes #1625