Metadata #1642
Metadata #1642
Conversation
ghost
self-requested a review
Codecov Report
@@ Coverage Diff @@
## master #1642 +/- ##
==========================================
+ Coverage 77.83% 77.87% +0.03%
==========================================
Files 232 234 +2
Lines 18209 18156 -53
==========================================
- Hits 14173 14139 -34
+ Misses 4036 4017 -19
Continue to review full report at Codecov.
|
| @@ -79,7 +79,7 @@ def search | |||
| start, stop = parse_time_input(x_start: params[:start], x_stop: params[:stop]) | |||
| q = params[:q] | |||
| raise NarrativeInputError "Must include q value" if q.nil? | |||
There was a problem hiding this comment.
Yeah I haven't made it up the chain yet to the controller and frontend
| @@ -79,7 +79,7 @@ def search | |||
| start, stop = parse_time_input(x_start: params[:start], x_stop: params[:stop]) | |||
| q = params[:q] | |||
| raise NarrativeInputError "Must include q value" if q.nil? | |||
| model_array = @model_class.get(scope: params[:scope], start: start, stop: stop) | |||
| model_array = @model_class.range(scope: params[:scope], start: start, stop: stop) | |||
| model_array.find { |model| model.description.include? q } | |||
There was a problem hiding this comment.
comment says "The string to contain in the narrative description". Worst variable name ever though.
| @@ -18,26 +18,25 @@ | |||
| # copyright holder | |||
|
|
|||
| require 'cosmos/models/metadata_model' | |||
| require 'time' | |||
|
|
|||
| class MetadataController < ApplicationController | |||
| def initialize | |||
| @model_class = Cosmos::MetadataModel | |||
| end | |||
|
|
|||
| def parse_time_input(x_start:, x_stop:) | |||
There was a problem hiding this comment.
What is this? Why does it default to +/- 7 days?
There was a problem hiding this comment.
I don't know but I didn't change it. It doesn't match the comment either which says start is minus 12 hrs and end is plus 2 days. I'm honestly not sure when the search feature is used.
No description provided.