#1303. Change the inject_tlm to directly modify the CVT packet object #1304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…instead of cloning.
mikemattball
changed the title
|
I was thinking more about this code last night. I think there could be a race condition because this inject_tlm is potentially happening in parallel with the interface_thread incoming telemetry. I'm guessing that's why the object was cloned, and why there was a note about possible confusion with checking the limits in the inject_tlm. I think the proper fix would be to mutex protect the object in both locations so only one could modify the object at a time. |
|
Fixed in #1363 |
ghost
closed this
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the inject_tlm method to directly modify the CVT packet object instead of cloning. This makes it so it is maintaining the limits status in the CVT object as well as any other state information that is lost with the previous cloning method.