Check syntax before instrumenting & remove require_utility #1082
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
self-requested a review
Codecov Report
@@ Coverage Diff @@
## master #1082 +/- ##
=======================================
Coverage 84.15% 84.15%
=======================================
Files 165 165
Lines 15746 15746
=======================================
Hits 13251 13251
Misses 2495 2495Continue to review full report at Codecov.
|
…ng multiple returns
|
I removed the lambda eval code, and some old monkey patches to the irb lexing code. Added a new monkey patch to keep the lexing code from looping forever in the given 'puts "#{foo"' case. Also discovered/fixed an instrumentation problem where multiple return values weren't working. Ready to merge. 👍 |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1081