Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include target REQUIRE files in marshal #980

Closed
ghost opened this issue Apr 17, 2019 · 0 comments · Fixed by #981
Closed

Include target REQUIRE files in marshal #980

ghost opened this issue Apr 17, 2019 · 0 comments · Fixed by #981
Labels
bug
Milestone
v4.4.0

Comments

@ghost
Copy link

ghost commented Apr 17, 2019

Describe the bug
The marshal code does not include files required by the target.txt REQUIRE keyword. This leads to old code being loaded when the server is restarted.

To Reproduce
Steps to reproduce the behavior:

  1. Require a conversion file in target.txt
  2. Launch the server
  3. Modify the conversion's initialize method
  4. Relaunch the server
  5. The old initialize code is loaded. However any new code in 'call' is run so it appears like all is well.
@ghost ghost self-assigned this Apr 17, 2019
@ghost ghost added the bug label Apr 17, 2019
@ghost ghost mentioned this issue Apr 17, 2019
Merged
ghost pushed a commit that referenced this issue Jun 27, 2019
@ryanmelt
re #980. Ensure @requires is absolute paths
f6faff7
@ghost ghost closed this as completed in #981 Jun 28, 2019
@ghost ghost added this to the v4.4.0 milestone Jul 2, 2019
@ghost ghost mentioned this issue Jul 23, 2019
Closed
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
v4.4.0
Development

Successfully merging a pull request may close this issue.

Add target.requires to md5 BallAerospace/COSMOS
0 participants