Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Add Color Uniform of CustomMaterial & PBRCustomMaterial #14558

Merged
merged 1 commit into from
Nov 29, 2023

Conversation

Starryi
Copy link
Contributor

@Starryi Starryi commented Nov 29, 2023

In CustomMaterial & PBRCustomMaterial, AddUniform can not pass color value to shader.

https://www.babylonjs-playground.com/#9ZQL2G can reproduce the bug.

@bjsplat
Copy link
Collaborator

bjsplat commented Nov 29, 2023

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Nov 29, 2023

@RaananW RaananW merged commit b2e91ba into BabylonJS:master Nov 29, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants