Document and Test Convolution #1104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shelhamer
force-pushed
the
conv-comments-tests
branch
from
2d27796 to
580fe67
Compare
|
|
| * inputs so that the im2col matrix has a column for each input region to | ||
| * be filtered. col2im restores the output spatial structure by rolling up | ||
| * the output channel N' columns of the output matrix. | ||
| * | ||
| * TODO(dox): thorough documentation for Forward, Backward, and proto params. |
|
probably worth switching to random weights, but I'll leave it up to you. otherwise LGTM! |
shelhamer
force-pushed
the
conv-comments-tests
branch
from
580fe67 to
6da8ce3
Compare
shelhamer
force-pushed
the
conv-comments-tests
branch
from
6da8ce3 to
7625cc5
Compare
To thoroughly check convolution, the output is compared against a reference implementation by explicit looping. Simple and group convolution by the Caffe and cuDNN engines are checked against the reference.
shelhamer
force-pushed
the
conv-comments-tests
branch
from
7625cc5 to
18ca362
Compare
|
Switched to random weights and uncovered a grouping issue in my reference convolution, so yeah, it was worth it. Ready for merge once Travis oks it. |
shelhamer
added a commit
that referenced
this pull request
Sep 18, 2014
Document and Test Convolution
mitmul
pushed a commit
to mitmul/caffe
that referenced
this pull request
Sep 30, 2014
Document and Test Convolution
RazvanRanca
pushed a commit
to RazvanRanca/caffe
that referenced
this pull request
Nov 4, 2014
Document and Test Convolution
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To thoroughly check convolution, the output is compared against a reference implementation by explicit looping. Simple and group convolution by the Caffe and cuDNN engines are checked against the reference.
The reference convolution rolls 8 loops deep.