Standardize Examples #1003
Merged
Standardize Examples #1003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shelhamer
force-pushed
the
examples-from-root
branch
from
0a43516 to
766e24f
Compare
| # 1. reference, and not casually committed | ||
| # 2. custom, and live on their own unless they're deliberated contributed | ||
| data/* | ||
| examples/* | ||
| *model | ||
| *.solverstate |
There was a problem hiding this comment.
this will miss the NetParameter binaryproto files which don't have an extension. Maybe should add something like *_iter_[0-9]+ (I have no idea what the gitignore regex syntax is like beyond *..)
(I've always thought the netparameter snapshots should have some kind of extension too...maybe at some point we could change both snapshot outputs to have clearer extensions like *.NetParameter.binaryproto and *.SolverState.binaryproto.)
There was a problem hiding this comment.
Thanks for the catch -- I'll add an ignore for iter_* for now but the model zoo PR will more thoroughly address this by introducing file extensions. This is just groundwork. Stay tuned.
shelhamer
force-pushed
the
examples-from-root
branch
from
766e24f to
c9f4688
Compare
- ignore models and snapshots, means, and input databases - excluding exceptions to commits is easier than including exhaustively
shelhamer
force-pushed
the
examples-from-root
branch
from
c9f4688 to
e793806
Compare
mitmul
pushed a commit
to mitmul/caffe
that referenced
this pull request
Sep 30, 2014
Standardize examples
RazvanRanca
pushed a commit
to RazvanRanca/caffe
that referenced
this pull request
Nov 4, 2014
Standardize examples
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preparation for #917 and #970.