Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed email module #361

Merged
merged 14 commits into from
Dec 23, 2024
Merged

Fixed email module #361

merged 14 commits into from
Dec 23, 2024

Conversation

svarona
Copy link
Member

@svarona svarona commented Dec 20, 2024 •
edited
Loading

Added param to pass template path

  • Added email password that was being unused
  • Explained help better
  • Added samples's batch number
  • Added invalid_samples folder explanation
  • Added minor fixed to e-mail template
  • Fixed log2excel error

@svarona svarona requested a review from Shettland December 20, 2024 12:17
Shettland
Shettland reviewed Dec 20, 2024
View reviewed changes
relecov_tools/mail.py Outdated Show resolved Hide resolved
@svarona svarona requested a review from Shettland December 20, 2024 13:57
Shettland
Shettland approved these changes Dec 20, 2024
View reviewed changes
Copy link
Member

@Shettland Shettland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@svarona svarona merged commit b3232f8 into BU-ISCIII:develop Dec 23, 2024
14 checks passed
@svarona svarona deleted the fix_logs_email branch December 23, 2024 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shettland Shettland Shettland approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@svarona @Shettland