Included pango-data version extraction in read-bioinfo-metadata #299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good! I agree is a little messy, it would be useful to include that versión in the versions.yml from viralrecon. I think that can be done without much problem, please add an issue in viralrecon, so any in nf-core can see and we'll discuss it with Sarai when she returns |
Done! nf-core/viralrecon#441 |
saramonzon
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per the title, I included a (in my opinion, messy) way to extract pango-data version and include it in the metadata when read-bioinfo-metadata is used for viralrecon. I call it messy because it revolves completely in our internal folder structure and won't work if that folder structure is changed.