Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade compat to julia 1.9 #10

Merged
merged 2 commits into from
Jul 6, 2023
Merged

Upgrade compat to julia 1.9 #10

merged 2 commits into from
Jul 6, 2023

Conversation

nbwuzhe
Copy link
Member

@nbwuzhe nbwuzhe commented Jul 6, 2023

Upgrade compat entries to julia 1.9

@nbwuzhe nbwuzhe requested review from mrikasper and alexjaffray July 6, 2023 15:17
@mrikasper mrikasper self-assigned this Jul 6, 2023
Copy link
Member

@mrikasper mrikasper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Maybe 1.9 (instead of 1.9.1) would also be sufficient for Project.toml,, but I believe it might not make a difference, according to https://pkgdocs.julialang.org/v1/compatibility/

Note, however, that for the 0.xx versions, 0.(xx+1) is considered to be incompatible, so we have to take care of that in the future.

@nbwuzhe nbwuzhe merged commit 704cc6c into main Jul 6, 2023
@nbwuzhe nbwuzhe deleted the update_to_1.9 branch January 30, 2024 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants