-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Drupal 8 support #16
base: master
Are you sure you want to change the base?
Conversation
@sergiuteaca, this commit e4c2c82 (https://github.com/BR0kEN-/TqExtension/pull/9) 4 breaks Drupal 8 adaptation. Could you remember why you've did it? |
…module on tests boot, add test for kernel placeholder
…r" compatible with "Drupal8Placeholder", implement "entityCreate()" method
… argument for "entityFieldValue()" method
@BR0kEN- because anonymous users were created without UID and this resulted in a fatal error |
@sergiuteaca I can't imagine how it is possible. Anonymous users cannot be created because they will not be anonymous since Also take a look at /**
* {@inheritdoc}
*/
public function isAuthenticated() {
return $this->id() > 0;
}
/**
* {@inheritdoc}
*/
public function isAnonymous() {
return $this->id() == 0;
} Before today I didn't care about that |
@sergiuteaca, I want you to provide a failing example/test case, if it will not be difficult to you. I would be thankful. |
@asgorobets, @Sanchiz, guys, you are welcome to review. Besides changes in this PR there is an interesting point with Travis: build on |
Shit, it fails even with Selenium2 session running on Selenium standalone server. Locally everything is fine using anyone: |
Also, @sergiuteaca, it's not possible to create a user without Here is the piece of if (!isset($account->is_new)) {
$account->is_new = empty($account->uid);
} More precisely possible, but with a strange implementation like: $user->is_new = false;
unset($user->uid); |
…ser) date pickers
…n that method does not exists
Thanks @arrrtem for testing this! |
@AlexNetman the commit above should fix "your" problem. |
…searching by text
Changes
Follow up: #13
Removed methods
Drupal\TqExtension\Context\RawTqContext
setDrupalVariables(array $variables)
Drupal\TqExtension\Utils\EntityDrupalWrapper
getFieldInstance($field_name)
getFieldInfo($field_name)
wrapper($data = null, array $info = [])
Drupal\TqExtension\Context\Redirect\RawRedirectContext
assertStatusCode($path, $code)
How to use it now
Install
Configure
Make sure you have correct version of
behat.yml
. Declaration ofTqExtension
there must be placed afterDrupalExtension
. Example:TqExtension/tests/behat/behat.yml
Lines 23 to 51 in efd22b3
To do
DatePicker
.