Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #103: Update doubleFilter.py #104

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
+5 −5
Open

Issue #103: Update doubleFilter.py #104

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e43aad1
Update doubleFilter.py
GonzoBS Nov 6, 2022
bd25ff7
Merge branch 'develop' into patch-1
janspeller Jan 24, 2023
37a1d08
Merge branch 'develop' into patch-1
Schrolli91 Jan 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions module/filter/doubleFilter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,11 @@ def onUnload(self):
def _check(self, bwPacket, filterFields):
self._filterLists[bwPacket.get("mode")].insert(0, bwPacket)

for listPacket in self._filterLists[bwPacket.get("mode")][1:]: # [1:] skip first entry, thats the new one
if all(listPacket.get(x) == bwPacket.get(x) for x in filterFields):
logging.debug("found duplicate: %s", bwPacket.get("mode"))
return False

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hier muss der Whitespace noch raus, damit die Tests durchlaufen

Suggested change

# delete entries that are to old
counter = 0
for listPacket in self._filterLists[bwPacket.get("mode")][1:]: # [1:] skip first entry, thats the new one
Expand All @@ -83,10 +88,5 @@ def _check(self, bwPacket, filterFields):
logging.debug("MaxEntry reached - delete oldest")
self._filterLists[bwPacket.get("mode")].pop()

for listPacket in self._filterLists[bwPacket.get("mode")][1:]: # [1:] skip first entry, thats the new one
if all(listPacket.get(x) == bwPacket.get(x) for x in filterFields):
logging.debug("found duplicate: %s", bwPacket.get("mode"))
return False

logging.debug("doubleFilter ok")
return None
Loading