Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Linear Elements Fast #850

Open
wants to merge 30 commits into
base: development
Choose a base branch
from
Open

Make Linear Elements Fast #850

wants to merge 30 commits into from

Conversation

ax3l
Copy link
Member

@ax3l ax3l commented Feb 12, 2025 •
edited
Loading

Make linear elements as fast as possible by:

  • calculating constants that depend on the element config and reference particle properties before pushing all particles,
  • instead of using a Matrix-Vector calculation (as in LinearElement), we rely on the fact that those matrices are sparse and keep the multiply-adds explicit.

Example: 1 CPU core run of a single Quad, 100M particles
Before:

Execution time ImpactX: 5.3057 seconds (0.05306us / particle)

Now:

Execution time ImpactX: 0.8723 seconds (0.00872us / particle)

Close #849

  • decide on general structure
  • go through all 40+ elements...

@ax3l ax3l requested review from RemiLehe and cemitch99 February 12, 2025 19:15
ax3l
ax3l commented Feb 12, 2025
View reviewed changes
@ax3l ax3l force-pushed the performance-quad-constants branch from 3c74ef7 to 9ed66b3 Compare February 12, 2025 19:33
@ax3l ax3l changed the title [Draft] Make Quad Fast [Draft] Make Quad & Drift Fast Feb 12, 2025
@ax3l ax3l force-pushed the performance-quad-constants branch 8 times, most recently from db2f5ac to 483e3df Compare February 15, 2025 00:38
@ax3l ax3l changed the title [Draft] Make Quad & Drift Fast [WIP] Make Linear Elements Fast Feb 15, 2025
ax3l
ax3l commented Feb 15, 2025
View reviewed changes
@ax3l ax3l force-pushed the performance-quad-constants branch 5 times, most recently from e9cf013 to 4b4919e Compare February 19, 2025 23:17
github-advanced-security[bot]
github-advanced-security bot found potential problems Feb 19, 2025
View reviewed changes
@ax3l ax3l force-pushed the performance-quad-constants branch 4 times, most recently from 9b7fedf to f0d27d5 Compare February 20, 2025 04:44
ax3l
ax3l commented Feb 20, 2025
View reviewed changes
@ax3l ax3l force-pushed the performance-quad-constants branch 2 times, most recently from 1aa4bb7 to b633a9b Compare February 20, 2025 06:34
ax3l added 29 commits February 20, 2025 11:03
@ax3l
Update Aperture
c0513f1
@ax3l
Make Alignment Fast
358de4f
@ax3l
Make Quad Fast
287742b 
Make the `Quad` fast by calculating constants that depend
on the element config and reference particle properties
before pushing all particles.
@ax3l
Make Drift Fast
824bac3
@ax3l
Make Buncher fast
8c07d2b
@ax3l
Make CFbend fast
27554e5
@ax3l
Make ChrDrift fast
8d0527b
@ax3l
Make ChrPlasmaLens faster
ed15b1c
@ax3l
Make ChrQuad faster
cfca6b7
@ax3l
Make ExactSbend faster
fc9d1fa
@ax3l
Make ConstF fast
9cc84bc
@ax3l
Make DipEdge fast
9e709b4
@ax3l
Make ChrUniformAcc faster
a9411ab
@ax3l
Update Empty to new APIs
7c93066
@ax3l
Make ExactDrift faster
c3886ce
@ax3l
Make Kicker faster
659643c
@ax3l
Update Marker to new APIs
9695046
@ax3l
Make Multipole faster
7e71a92
@ax3l
Make NonlinearLens faster
2e48acc
@ax3l
Make PlaneXYRot fast
620c4f1
@ax3l
Make PRot fast
f3d5281
@ax3l
Make RFCavity faster
3fcc04c
@ax3l
Make Sbend fast
062acc5
@ax3l
Make ShortRF faster
5143e8e
@ax3l
Make SoftQuad faster
9eed490
@ax3l
Make SoftSol faster
8949605
@ax3l
Make Sol fast
3b7324a
@ax3l
Make ThinDipole fast
860b4f3
@ax3l
LinearMap use restrict
a9ccaa5
@ax3l ax3l force-pushed the performance-quad-constants branch from b633a9b to a9ccaa5 Compare February 20, 2025 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RemiLehe RemiLehe Awaiting requested review from RemiLehe

@cemitch99 cemitch99 Awaiting requested review from cemitch99

Assignees
No one assigned
Labels
component: elements Elements/external fields Performance optimization
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Optimize Lattice: Pre-Calc Constants
2 participants
@ax3l @cemitch99