CMake: Lib & Python Consistency #274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ax3l
added
bug
ax3l
commented
Nov 2, 2022
| @@ -123,9 +128,6 @@ endif() | |||
|
|
|||
| # Targets ##################################################################### | |||
| # | |||
| if(ImpactX_PYTHON) | |||
There was a problem hiding this comment.
logic in cmake/dependencies/ABLASTR.cmake depends on a correctly set ImpactX_LIB, so we need to move it up before including that file
ax3l
commented
Nov 2, 2022
| @@ -287,7 +287,7 @@ function(impactx_set_binary_name) | |||
| ) | |||
| endif() | |||
| if(ImpactX_LIB) | |||
| if(WIN32) | |||
| if(WIN32) # TODO: handle static lib extensions | |||
There was a problem hiding this comment.
Probably the reason for the issue in #208, will be fixed therein
This comment was marked as resolved.
This comment was marked as resolved.
Fix the logic of forcing the lib build for Python bindings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the logic of forcing the lib build for Python bindings.