Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean imports #83

Merged
merged 15 commits into from
Mar 30, 2022
Merged

Clean imports #83

merged 15 commits into from
Mar 30, 2022

Conversation

shawntanzk
Copy link
Contributor

@shawntanzk shawntanzk commented Feb 24, 2022

@patrick-lloyd-ray - I've moved this to merged imports
I've added a bunch of imports that you did not tick as it makes the ontology a bit cleaner to look at (esp if users entry to it is directly through protege)
Please do take a look at the -edit file for now, if you are ok I will make a release based on this.
If the ontology looks a bit difficult to navigate now, a possibility is for us to launch a customised OLS instance for this ontology in a AWS server or something - from there you can control what the root nodes are and hence what your users see.
For updating imports, you can add the terms (eg you want to add a OBI term) to obi_terms.txt as usually, but then running make imports/merged_imports.owl instead

Fixes #76

@shawntanzk
Copy link
Contributor Author

error:

2022-02-24 08:49:35,072 ERROR org.obolibrary.robot.ReasonOperation - Equivalence: <http://purl.obolibrary.org/obo/UO_0010048> == <http://purl.obolibrary.org/obo/UO_0000039>
2022-02-24 08:49:35,072 ERROR org.obolibrary.robot.ReasonOperation - Equivalence: <http://purl.obolibrary.org/obo/UO_0000176> == <http://purl.obolibrary.org/obo/UO_0000273>

will remove them given UO isn't needed

@shawntanzk
Copy link
Contributor Author

shawntanzk commented Feb 24, 2022

Current error with DL profile, all coming from this pattern:

Not enough operands; at least two needed: ObjectIntersectionOf(ObjectIntersectionOf(<http://purl.obolibrary.org/obo/OBI_0100051> ObjectSomeValuesFrom(<http://purl.obolibrary.org/obo/OBI_0000312> <http://purl.obolibrary.org/obo/OBI_0600005>) ObjectSomeValuesFrom(<http://purl.obolibrary.org/obo/RO_0001000> <http://purl.obolibrary.org/obo/**TERM**>))) [EquivalentClasses(<http://purl.obolibrary.org/obo/**TERM**> ObjectIntersectionOf(ObjectIntersectionOf(<http://purl.obolibrary.org/obo/OBI_0100051> ObjectSomeValuesFrom(<http://purl.obolibrary.org/obo/OBI_0000312> <http://purl.obolibrary.org/obo/OBI_0600005>) ObjectSomeValuesFrom(<http://purl.obolibrary.org/obo/RO_0001000> <http://purl.obolibrary.org/obo/**TERM**>))) ) in OntologyID(OntologyIRI(<http://purl.obolibrary.org/obo/tmn.owl>) VersionIRI(<http://purl.obolibrary.org/obo/tmn/releases/2022-02-24/tmn.owl>))]`

@shawntanzk
Copy link
Contributor Author

Probably this pattern
Screenshot 2022-02-24 at 09 15 27

@shawntanzk
Copy link
Contributor Author

see obi-ontology/obi#1500 (comment) for details

@shawntanzk
Copy link
Contributor Author

disabled the check for now, will make a ticket to reinstate once we can figure it out with OBI :)

@shawntanzk
Copy link
Contributor Author

shawntanzk commented Feb 24, 2022

ODK 1.3.0 seems to have some issue with DOSDP stuff, will revert for now

Issue was with QC using an old ODK - should be fixed now

@patrick-lloyd-ray patrick-lloyd-ray merged commit af80b9d into BICCN:main Mar 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix imports
2 participants