-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean imports #83
Merged
Merged
Clean imports #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
error:
will remove them given UO isn't needed |
Current error with DL profile, all coming from this pattern:
|
see obi-ontology/obi#1500 (comment) for details |
disabled the check for now, will make a ticket to reinstate once we can figure it out with OBI :) |
ODK 1.3.0 seems to have some issue with DOSDP stuff, will revert for now Issue was with QC using an old ODK - should be fixed now |
This reverts commit 3703b7b.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@patrick-lloyd-ray - I've moved this to merged imports
I've added a bunch of imports that you did not tick as it makes the ontology a bit cleaner to look at (esp if users entry to it is directly through protege)
Please do take a look at the -edit file for now, if you are ok I will make a release based on this.
If the ontology looks a bit difficult to navigate now, a possibility is for us to launch a customised OLS instance for this ontology in a AWS server or something - from there you can control what the root nodes are and hence what your users see.
For updating imports, you can add the terms (eg you want to add a OBI term) to obi_terms.txt as usually, but then running
make imports/merged_imports.owl
insteadFixes #76