Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix apparently code quality issues highlighted by SonarCloud #606

Merged
merged 1 commit into from
Aug 1, 2024

Conversation

BareMaxx
Copy link
Contributor

@BareMaxx BareMaxx commented Aug 1, 2024

Sonarcloud complained hence marking the checks as failed. This should make Sonarcloud happy as all these changes were requested by Sonarcloud. Lol.

@BareMaxx BareMaxx requested a review from Andreasgdp August 1, 2024 20:51
@BareMaxx BareMaxx self-assigned this Aug 1, 2024
@BareMaxx BareMaxx linked an issue Aug 1, 2024 that may be closed by this pull request
Copy link

stackblitz bot commented Aug 1, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

vercel bot commented Aug 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
moment-meal ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 1, 2024 8:54pm

Copy link

sonarqubecloud bot commented Aug 1, 2024

@BareMaxx BareMaxx changed the title Fixed the issues where Sonacloud complained Fix apparently code quality issues highlighted by SonarCloud Aug 1, 2024
@BareMaxx
Copy link
Contributor Author

BareMaxx commented Aug 1, 2024

Look at all those green checkmarks, nice! (❤ ω ❤) ᕦ(ò_óˇ)ᕤ

@Andreasgdp Andreasgdp merged commit 0674554 into master Aug 1, 2024
7 checks passed
@Andreasgdp Andreasgdp deleted the fix-605-make-sonarcloud-happy branch August 1, 2024 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Make SonarCloud happy
2 participants