-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates to PVPostionerSoftDone #1005
Merged
gfabbris
merged 27 commits into
BCDA-APS:916-PVPositionerSoftDone-update
from
gfabbris:pvpositioner
Aug 26, 2024
Merged
Changes from all commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
d1b264a
MNT #975 2M undulator
prjemian ab0bf00
TST #975
prjemian 5271e4e
TST #975 use dummy PVs for testing
prjemian 7676185
TST #975 increase master timeout
prjemian cfc83bf
TST #975 generalize
prjemian 55f2301
ENH #976 4M object seems identical to 2M
prjemian d4592f6
TST #976
prjemian efdd604
DOC #1002
prjemian 60a4166
MNT #976 re-use rather than repeat
prjemian d423327
Merge pull request #1002 from BCDA-APS/975-2M-undulator
prjemian 93fe31a
DOC catch-up
prjemian 69bdc95
PKG #993 numpy is pinned
prjemian 5e525a4
release 1.6.20
prjemian 9a5afb9
DOC missed the release with this
prjemian 80bb624
Merge pull request #1 from BCDA-APS/916-PVPositionerSoftDone-update
gfabbris 40acf1e
update positioner_soft_done
gfabbris c77c503
remove unused import
gfabbris 029d3ef
re-add logger
gfabbris d0d46af
tweaks and cleanup
gfabbris 633802c
update eurotherm to `use_target`
gfabbris 2b3d5ce
tweak test to use_target=True
gfabbris a05c3fc
tweaks
gfabbris 4dc5dc3
debug
gfabbris 8bce07e
Force done to be False in the start of the motion
gfabbris 0e32b4a
python 3.8 breaking test
gfabbris 4ef2ab5
add use_target=True to lakeshores
gfabbris 791232a
retrigger checks
gfabbris File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're really close to EOL for Py3.8. This would push the entire repo to drop it. What breaks for Py3.8 now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I came across this import error.