Skip to content

Commit

Permalink
MNT #984 switch bases and plugins to kwargs
Browse files Browse the repository at this point in the history
  • Loading branch information
prjemian committed Aug 24, 2024
1 parent b8faef6 commit 124c179
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
4 changes: 3 additions & 1 deletion apstools/devices/area_detector_factory.py
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,7 @@
"""Default plugin configuration dictionary."""


def ad_class_factory(name, bases, plugins, plugin_defaults=None):
def ad_class_factory(name, bases=None, plugins=None, plugin_defaults=None):
"""
Build an Area Detector class with specified plugins.
Expand All @@ -175,12 +175,14 @@ def ad_class_factory(name, bases, plugins, plugin_defaults=None):
plugins
*list* :
Description of the plugins used.
(default: ``["cam"]`` -- Just the camera plugin.)
plugin_defaults
*object*:
Plugin configuration dictionary.
(default: ``None``, PLUGIN_DEFAULTS will be used.)
"""
bases = bases or (SingleTrigger_V34, DetectorBase)
plugins = plugins or ["cam"]
plugin_defaults = plugin_defaults or PLUGIN_DEFAULTS

attributes = {}
Expand Down
2 changes: 1 addition & 1 deletion apstools/devices/tests/test_issue984_ad_factory.py
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@


def test_my_fake_area_detector():
ad_class = ad_class_factory("FakeAD", None, ["cam"])
ad_class = ad_class_factory("FakeAD")
fake_ad = make_fake(ad_class, prefix="Fake:AD", name="fake_ad")
assert "cam.acquire_time" not in fake_ad.stage_sigs

Expand Down

0 comments on commit 124c179

Please sign in to comment.