fix(pi): JavaScript error when a PI does not exists

Closes #DOST05-582
BBVA · Jan 24, 2018 · 1011b66 · 1011b66
1 parent d468f88
commit 1011b66
Show file tree

Hide file tree

Showing 6 changed files with 32 additions and 24 deletions.
diff --git a/mirrorgate-dashboard/src/components/tiles/programIncrement/component.html b/mirrorgate-dashboard/src/components/tiles/programIncrement/component.html
@@ -198,7 +198,7 @@ <h3 class="title-desc" rv-hide="programIncrement.features">No data for PI</h3>
           }
 
 
-          model.programIncrement.products.forEach(function(product) {
+          model.programIncrement.products && model.programIncrement.products.forEach(function(product) {
             //All product should take the same space, so we take a count of
             //per product totals to use them as factor
             let productStories = 0;

diff --git a/mirrorgate-dashboard/src/components/tiles/programIncrement/controller.js b/mirrorgate-dashboard/src/components/tiles/programIncrement/controller.js
@@ -160,7 +160,7 @@ var ProgramIncrementController = (
     }
 
     this.getProgramIncrementStatus = function (programIncrement) {
-      if(!programIncrement) return;
+      if(!programIncrement || !programIncrement.endDate) return;
 
       var totalWorkingDays = Utils.getWorkingDays(programIncrement.startDate,programIncrement.endDate);
       var remainingWorkingDays = programIncrement.getDaysLeft();

diff --git a/mirrorgate-dashboard/src/components/tiles/programIncrement/simple-pi.html b/mirrorgate-dashboard/src/components/tiles/programIncrement/simple-pi.html
@@ -90,36 +90,41 @@ <h2 class="title" rv-hide="programIncrement.features">No data for PI</h2>
           let format = "MMMM Do";
 
           model.programIncrement = data;
-          model.daysLeft = data.getDaysLeft();
+
+          if(data.endDate) {
+            model.daysLeft = data.getDaysLeft();
+          }
 
           if (data.startDate){
             model.dateRange = moment(data.startDate).format(format) + ' - ' + moment(data.endDate).format(format);
           }
 
-          model.items = [];
-          var remain = 100;
-
-
-          for(var i in order) {
-            var width = 100 * data.report.perStatus[i] / data.report.totalEstimate;
-            if(width) {
-              remain -= width;
-              if(!model.items[i]) {
-                model.items.push({
-                  status: i,
-                  width: width
-                });
-              } else {
-                model.items[i].width += width;
+          if(data.report) {
+
+            model.items = [];
+            var remain = 100;
+
+            for(var i in order) {
+              var width = 100 * data.report.perStatus[i] / data.report.totalEstimate;
+              if(width) {
+                remain -= width;
+                if(!model.items[i]) {
+                  model.items.push({
+                    status: i,
+                    width: width
+                  });
+                } else {
+                  model.items[i].width += width;
+                }
               }
             }
-          }
 
-          if(remain && remain > 0.01) {
-            model.items.push({
-              status: 'remain',
-              width: remain
-            });
+            if(remain && remain > 0.01) {
+              model.items.push({
+                status: 'remain',
+                width: remain
+              });
+            }
           }
         }
       }

diff --git a/mirrorgate-dashboard/test/mocks/dashboards/empty/details b/mirrorgate-dashboard/test/mocks/dashboards/empty/details
@@ -6,6 +6,7 @@
   "boards": [
     "empty"
   ],
+  "programIncrement": "empty",
   "applications": ["empty"],
   "slackTeam": "empty",
   "urlAlerts": "dashboards/empty/alerts",

diff --git a/mirrorgate-dashboard/test/mocks/dashboards/empty/programincrement b/mirrorgate-dashboard/test/mocks/dashboards/empty/programincrement
@@ -0,0 +1 @@
+{}
diff --git a/mirrorgate-dashboard/test/mocks/dashboards/errors/details b/mirrorgate-dashboard/test/mocks/dashboards/errors/details
@@ -7,6 +7,7 @@
   "boards": [
    "error"
   ],
+  "programIncrement": "error",
   "applications": ["error"],
   "slackTeam":"error",
   "urlAlerts": "error",