This repository has been archived by the owner on Aug 13, 2023. It is now read-only.
Update Headline & Subheading colour to Shadow #305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dr3 Yes. I've pushed that change. |
sareh
commented
Feb 25, 2019
| @@ -43,6 +43,13 @@ const GlobalStyle = createGlobalStyle` | |||
| font-weight: 600; | |||
| src: url('https://gel.files.bbci.co.uk/r2.302/BBCReithSerif_W_Md.woff2') format('woff2'), url('https://gel.files.bbci.co.uk/r2.302/BBCReithSerif_W_Md.woff') format('woff'); | |||
| } | |||
| @font-face { | |||
There was a problem hiding this comment.
I added this so the Reith Sans Bold font will load in Storybook. Though issue #285 updating font-faces within Psammead utilities will be used to update the font-faces in the Storybook config.
dr3
reviewed
Feb 25, 2019
dr3
approved these changes
Feb 26, 2019
|
👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #279
Overall change: Update Headline & Subheading colour to Shadow
'#3F3F42'& Subheading updated to use Reith Sans Bold font.Screenshots of Storybook for Headline, with dev tools showing color is Shadow & font is unchanged:
Subheading component shows color is Shadow and font updated to Reith Sans Bold:
