You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Aug 13, 2023. It is now read-only.
Is your feature request related to a problem? Please describe.
Now that #304 is merged (as a result of investigation #285), we should update all relevant components to use the new font-face declarations.
Describe the solution you'd like
Update these components to import font-face declarations from psammead-styles/fonts. The snapshots should be updated to show the new names e.g. ReithSans and ReithSerif. To enable all of the fonts to be loaded into storybook, we'd need to import the relevant values from psammead-styles/fonts into .storybook/config.js
Patch release - therefore no corresponding PR required in Simorgh, as the updates should be pulled in automatically.
Describe alternatives you've considered
N/A
Testing notes
High level regression of Psammead to make sure that nothing has gone wrong.
Dev insight: Manual checking in Storybook that everything is updated, and snapshot tests should be updated (CMD + F "ReithSans" and "ReithSerif" should appear).
Is your feature request related to a problem? Please describe.
Now that #304 is merged (as a result of investigation #285), we should update all relevant components to use the new font-face declarations.
Describe the solution you'd like
Update these components to import font-face declarations from
psammead-styles/fonts
. The snapshots should be updated to show the new names e.g.ReithSans
andReithSerif
. To enable all of the fonts to be loaded into storybook, we'd need to import the relevant values frompsammead-styles/fonts
into.storybook/config.js
Patch release - therefore no corresponding PR required in Simorgh, as the updates should be pulled in automatically.
Describe alternatives you've considered
N/A
Testing notes
High level regression of Psammead to make sure that nothing has gone wrong.
Dev insight: Manual checking in Storybook that everything is updated, and snapshot tests should be updated (
CMD + F
"ReithSans" and "ReithSerif" should appear).The text was updated successfully, but these errors were encountered: