Skip to content
This repository has been archived by the owner on Aug 13, 2023. It is now read-only.

Use updated font-face declarations #312

Closed
1 task done
sareh opened this issue Feb 26, 2019 · 0 comments
Closed
1 task done

Use updated font-face declarations #312

sareh opened this issue Feb 26, 2019 · 0 comments
Assignees

Comments

@sareh
Copy link
Contributor

sareh commented Feb 26, 2019

Is your feature request related to a problem? Please describe.
Now that #304 is merged (as a result of investigation #285), we should update all relevant components to use the new font-face declarations.

psammead-caption
psammead-copyright
psammead-headings
psammead-paragraph
psammead-sitewide-links

Describe the solution you'd like
Update these components to import font-face declarations from psammead-styles/fonts. The snapshots should be updated to show the new names e.g. ReithSans and ReithSerif. To enable all of the fonts to be loaded into storybook, we'd need to import the relevant values from psammead-styles/fonts into .storybook/config.js

Patch release - therefore no corresponding PR required in Simorgh, as the updates should be pulled in automatically.

Describe alternatives you've considered
N/A

Testing notes
High level regression of Psammead to make sure that nothing has gone wrong.

Dev insight: Manual checking in Storybook that everything is updated, and snapshot tests should be updated (CMD + F "ReithSans" and "ReithSerif" should appear).

@sareh sareh added Refinement Needed This is ready for refinement. It shouldn't be worked on until it has been refined by Dev & Test. v1.0 labels Feb 26, 2019
@ChrisBAshton ChrisBAshton removed the Refinement Needed This is ready for refinement. It shouldn't be worked on until it has been refined by Dev & Test. label Mar 4, 2019
@dr3 dr3 self-assigned this Mar 4, 2019
@dr3 dr3 closed this as completed in #318 Mar 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants