This repository has been archived by the owner on Aug 13, 2023. It is now read-only.
Update package versions to v1 #679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
self-assigned this
ghost
marked this pull request as ready for review
DenisHdz
reviewed
Jun 24, 2019
| @@ -3,5 +3,6 @@ | |||
| <!-- prettier-ignore --> | |||
| | Version | Description | | |||
| | ------- | ----------- | | |||
| | 1.0.0-alpha.0 | [PR#679](https://github.com/BBC-News/psammead/pull/679) Bump version number | | |||
There was a problem hiding this comment.
I am not sure if we should bump the alpha components. For example here, it is supposed that 0.1.0-alpha.2 is a pre-release for version 0.1.0 and I would be expecting a bump to 0.1.0 once it is a stable version.
j-pendlebury
approved these changes
Jun 24, 2019
DenisHdz
approved these changes
Jun 24, 2019
|
Looks fine, this is ready for merge. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #650
Overall change: Bump package versions to
1.0.0Code changes: